Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azfile: OAuth support #21088

Merged
merged 10 commits into from
Jul 3, 2023
Merged

azfile: OAuth support #21088

merged 10 commits into from
Jul 3, 2023

Conversation

souravgupta-msft
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jun 30, 2023
@souravgupta-msft
Copy link
Member Author

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member Author

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft souravgupta-msft added this to the azfile v0.2.0 milestone Jun 30, 2023
seanmcc-msft
seanmcc-msft reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@seanmcc-msft seanmcc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we should get an approval from a colleague who has more Go context than me.

sdk/storage/azfile/fileerror/error_codes.go Show resolved Hide resolved
tasherif-msft
tasherif-msft approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@tasherif-msft tasherif-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@souravgupta-msft souravgupta-msft merged commit 852b22e into Azure:feature/azfile Jul 3, 2023
@souravgupta-msft souravgupta-msft deleted the sourav/oauth branch July 3, 2023 05:24
souravgupta-msft added a commit to souravgupta-msft/azure-sdk-for-go that referenced this pull request Jul 19, 2023
@souravgupta-msft
azfile: OAuth support (Azure#21088)
83ff8c0
souravgupta-msft added a commit that referenced this pull request Jul 20, 2023
@souravgupta-msft
azfile: sync with main (#21216)
97e0693 
* azfile: upgrade to STG 87 (#20871)

* azfile: OAuth support (#21088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmcc-msft seanmcc-msft seanmcc-msft left review comments

@tasherif-msft tasherif-msft tasherif-msft approved these changes

@vibhansa-msft vibhansa-msft vibhansa-msft approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@siminsavani-msft siminsavani-msft Awaiting requested review from siminsavani-msft

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

Assignees
No one assigned
Labels
AzFile Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
azfile v1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.
5 participants
@souravgupta-msft @seanmcc-msft @gapra-msft @vibhansa-msft @tasherif-msft